Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass --tests flag to gometalinter so that we lint test files #1563

Merged
merged 2 commits into from
Nov 6, 2017
Merged

Pass --tests flag to gometalinter so that we lint test files #1563

merged 2 commits into from
Nov 6, 2017

Commits on Nov 5, 2017

  1. Pass --tests flag to gometalinter so that we lint test files 

    Previously we'd lint test files. In the recent PR
alecthomas/gometalinter#377, gometalinter stopped asking errcheck to
lint tests. This change makes us again lint test files which I think is
sensible.
    @horgh
    horgh committed Nov 5, 2017
    Configuration menu
    Copy the full SHA
    70ecda3 View commit details
    Browse the repository at this point in the history

  2. Add --tests only when using the default gometalinter command 

    This avoids adding the flag if the option to set the gometalinter
command is set.
    @horgh
    horgh committed Nov 5, 2017
    Configuration menu
    Copy the full SHA
    770164a View commit details
    Browse the repository at this point in the history