Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s): BT-3938
Problem
x-timeout-ms
instead ofx-query-timeout-ms
5000.0
instead of5000
Solution
Update the header and header encoding.
Result
Query timeouts are enforced correctly.
Testing
Added a test that
QueryTimeoutError
s get raised when queries run beyond the specifiedquery_timeout
configuration.Added a test for
Client.paginate
that uses query timeouts to demonstrate that options are getting passed down to requests.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.