Encode Query timeout header correctly #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnwpedro
force-pushed
the
query-timeout-client-config
branch
from
3864796 to
e629c04
Compare
pnwpedro
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s): BT-3997
fixes #126
Problem
When the
query_timeoutoption is provided to the client configuration, theX-Query-Timeout-Msheader gets encoded as a decimal. e.g. "5000.0" instead of "5000". Fauna returns a 400 error when this happens.Solution
Make sure that the header is encoded as an integer.
We did this for when the query timeout is configured in QueryOptions (see #124), but we didn't cover the client config path.
Add test coverage for configuring and actually sending a request.
Result
Clients can be configured with query_timeout and Fauna will respect it.
Testing
Added a test to actually send requests with a client configured with query_timeout. One request with client config and one request with no client config but with QueryOptions.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.