Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor "Anonymous SID/Name translation" check #514

Closed
TuemmlerKelch opened this issue Feb 19, 2024 · 0 comments
Closed

Refactor "Anonymous SID/Name translation" check #514

TuemmlerKelch opened this issue Feb 19, 2024 · 0 comments
Assignees
@SteffenWinternheimer
Labels
enhancement New feature or request minor Incremental updates and enhancements for improved functionality without major changes.
Milestone
5.9.0

Comments

@TuemmlerKelch
Copy link
Collaborator

TuemmlerKelch commented Feb 19, 2024 •
edited
Loading

Please move away from registry-based testing towards security options.

Proper implementation example:
https://github.com/fbprogmbh/Audit-Test-Automation/blob/master/ATAPAuditor/AuditGroups/Microsoft%20Windows%2010-DISA-1.23%23SecurityOptions.ps1#L105

setting this via registry value TurnOffAnonymousBlock is wrong.
@TuemmlerKelch TuemmlerKelch added enhancement New feature or request minor Incremental updates and enhancements for improved functionality without major changes. labels Feb 19, 2024
@TuemmlerKelch TuemmlerKelch added this to the 5.9.0 milestone Feb 19, 2024
@TuemmlerKelch TuemmlerKelch changed the title Microsoft Windows 10 SiSyPHuS NE-BSI-1.3: Refactor "Anonymous SID/Name translation" check Refactor "Anonymous SID/Name translation" check Mar 13, 2024
SteffenWinternheimer pushed a commit that referenced this issue Mar 13, 2024
Update logic and move AuditTests #514
a012993
Merged
TuemmlerKelch added a commit that referenced this issue Mar 15, 2024
@TuemmlerKelch
Merge pull request #526 from fbprogmbh/ticket_514
a352525 
Update logic and move AuditTests #514
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SteffenWinternheimer SteffenWinternheimer

Labels
enhancement New feature or request minor Incremental updates and enhancements for improved functionality without major changes.
Projects
None yet
Milestone
5.9.0
Development

No branches or pull requests
2 participants
@SteffenWinternheimer @TuemmlerKelch