-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flatten configuration structure for online store #1459
Conversation
Signed-off-by: Willem Pienaar <git@willem.co>
Signed-off-by: Willem Pienaar <git@willem.co>
Signed-off-by: Willem Pienaar <git@willem.co>
Signed-off-by: Willem Pienaar <git@willem.co>
bff5185
to
4bbbeb6
Compare
Signed-off-by: Willem Pienaar <git@willem.co>
@@ -63,7 +65,7 @@ class RepoConfig(FeastBaseModel): | |||
provider: StrictStr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'll need defaults for provider and project in order for RepoConfig()
with no arguments to work
fyi there's an empty file |
Signed-off-by: Willem Pienaar <git@willem.co>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jklegar, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Signed-off-by: Willem Pienaar git@willem.co
What this PR does / why we need it:
The current configuration structure requires a nested
online_store
configuration like thisThis refactor moves to
but allows for a default type to be set, based on the provider.
Much of the work in this PR is just to ensure that exceptions are clear to the user.
Does this PR introduce a user-facing change?: