Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change FeatureStore default config to read from current directory #1462

Closed
wants to merge 1 commit into from

Conversation

jklegar
Copy link
Collaborator

@jklegar jklegar commented Apr 13, 2021

Signed-off-by: Jacob Klegar jacob@tecton.ai

What this PR does / why we need it: Change FeatureStore default config to read from current directory instead of using a fixed default config

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Running `FeatureStore()` without any arguments now looks in the current working directory for a `feature_store.yaml` file instead of using a fixed default config.

Signed-off-by: Jacob Klegar <jacob@tecton.ai>
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jklegar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jklegar
Copy link
Collaborator Author

jklegar commented Apr 13, 2021

/kind housekeeping

@woop
Copy link
Member

woop commented Apr 13, 2021

@jklegar its not clear what the default behaviour is here. Is it

# reads from repository at current location?
fs = FeatureStore()

wouldn't that fail in most cases if the user hasn't run init?

@jklegar jklegar closed this Apr 13, 2021
@jklegar
Copy link
Collaborator Author

jklegar commented Apr 13, 2021

covered by #1459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants