BigQuery type to Feast type conversion chart update #1530
Conversation
mavysavydav
requested review from
jklegar,
tsotnet,
woop and
a team
as code owners
|
Hi @mavysavydav. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
docs/specs/offline_store_format.md
Outdated
| @@ -62,10 +62,10 @@ Here's how Feast types map to BigQuery types when using BigQuery for offline sto | |||
| | Event Timestamp | `DATETIME` | | |||
| | BYTES | `BYTES` | | |||
| | STRING | `STRING` | | |||
| | INT32 | `INT64` | | |||
| | INT32 | `INTEGER` | | |||
There was a problem hiding this comment.
https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#integer_type INT64 and FLOAT64 seem like correct data type.
docs/specs/offline_store_format.md
Outdated
| | INT64 | `INT64` | | ||
| | DOUBLE | `FLOAT64` | | ||
| | FLOAT | `FLOAT64` | | ||
| | FLOAT | `FLOAT` | |
There was a problem hiding this comment.
https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#integer_type INT64 and FLOAT64 seem like correct data type.
There was a problem hiding this comment.
@tedhtchang apologies, you're right. I've corrected my suggestion. Since 'INTEGER' and 'FLOAT' are seen in various places in BQ usage/ecosystem, it may be helpful to have these types explicitly written in the chart.
There was a problem hiding this comment.
I've also renamed the PR to be for a chart "update" rather than a "fix"
mavysavydav
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jklegar, mavysavydav The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/kind housekeeping |
|
/lgtm |
* BigQuery type to Feast type chart fixes * Updating correction to be accurate
* BigQuery type to Feast type chart fixes * Updating correction to be accurate
What this PR does / why we need it: Documentation update
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: