Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigQuery type to Feast type conversion chart update #1530

Merged
merged 2 commits into from
May 4, 2021
Merged

BigQuery type to Feast type conversion chart update #1530

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93cf668
BigQuery type to Feast type chart fixes
mavysavydav May 1, 2021
629f459
Updating correction to be accurate
mavysavydav May 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/specs/offline_store_format.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,10 @@ Here's how Feast types map to BigQuery types when using BigQuery for offline sto
| Event Timestamp | `DATETIME` |
| BYTES | `BYTES` |
| STRING | `STRING` |
| INT32 | `INT64` |
| INT32 | `INTEGER` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#integer_type INT64 and FLOAT64 seem like correct data type.

| INT64 | `INT64` |
| DOUBLE | `FLOAT64` |
| FLOAT | `FLOAT64` |
| FLOAT | `FLOAT` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#integer_type INT64 and FLOAT64 seem like correct data type.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tedhtchang apologies, you're right. I've corrected my suggestion. Since 'INTEGER' and 'FLOAT' are seen in various places in BQ usage/ecosystem, it may be helpful to have these types explicitly written in the chart.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also renamed the PR to be for a chart "update" rather than a "fix"

| BOOL | `BOOL`|
| BYTES\_LIST | `ARRAY<BYTES>` |
| STRING\_LIST | `ARRAY<STRING>`|
Expand All @@ -75,4 +75,4 @@ Here's how Feast types map to BigQuery types when using BigQuery for offline sto
| FLOAT\_LIST | `ARRAY<FLOAT64>`|
| BOOL\_LIST | `ARRAY<BOOL>`|

Values that are not specified by the table above will cause an error on conversion.
Values that are not specified by the table above will cause an error on conversion.