-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating CLI apply to use FeatureStore & remove feature table logic #1741
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: adchia The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @jklegar |
Codecov Report
@@ Coverage Diff @@
## master #1741 +/- ##
===========================================
- Coverage 79.10% 62.11% -16.99%
===========================================
Files 81 79 -2
Lines 6938 6834 -104
===========================================
- Hits 5488 4245 -1243
- Misses 1450 2589 +1139
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Looks good to me. I wonder if we should change the |
Moving to different PR since I added a dev branch to the main repo |
What this PR does / why we need it:
Moves the feast CLI's apply method (
feast apply
) to use the SDK FeatureStore class more. This includes some cleanup that also removes obsolete logic around feature tables. Note that because the feast CLI's apply is a total apply whereas the SDK apply is partial, there is still leftover business logic (in particular for deleting entities / FVs that don't match the repo).Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?: