Updating CLI apply to use FeatureStore #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1745 +/- ##
===========================================
- Coverage 83.85% 64.02% -19.84%
===========================================
Files 73 71 -2
Lines 6009 5935 -74
===========================================
- Hits 5039 3800 -1239
- Misses 970 2135 +1165
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Note: going to re-add in feature table logic as per comments in #1741 |
achals
reviewed
Jul 29, 2021
done! |
achals
approved these changes
Aug 2, 2021
tedhtchang
reviewed
Aug 2, 2021
docs/README.md
Outdated
| @@ -2,27 +2,27 @@ | |||
|
|
|||
| ## What is Feast? | |||
|
|
|||
| Feast \(**Fea**ture **St**ore\) is an operational data system for managing and serving machine learning features to models in production. | |||
| Feast \(**Fea**ture **St**ore\) is an operational data system for managing and serving machine learning features to models in production. It can serve features from a low-latency offline store \(for real-time prediction\) or from an off-line store \(for scale-out batch scoring or training models\). | |||
There was a problem hiding this comment.
Suggested change
| Feast \(**Fea**ture **St**ore\) is an operational data system for managing and serving machine learning features to models in production. It can serve features from a low-latency offline store \(for real-time prediction\) or from an off-line store \(for scale-out batch scoring or training models\). | |
| Feast \(**Fea**ture **St**ore\) is an operational data system for managing and serving machine learning features to models in production. It can serve features from a low-latency online store \(for real-time prediction\) or from an offline store \(for scale-out batch scoring or training models\). |
There was a problem hiding this comment.
will address this in a followup PR since this is from a separate merge
tedhtchang
reviewed
Aug 2, 2021
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| Feast manages two important sets of configuration: feature definitions, and configuration about how to run the feature store. With Feast, this configuration can be written declaratively and stored as code in a central location. This central location is called a feature repository, and it's essentially just a directory that contains some code files. | |||
|
|
|||
| Feast manages two important sets of configuration: feature definitions, and configuration about how to run the feature store. With Feast, this configuration can be written declaratively and stored as code in a central location. This central location is called a feature repository, and it's essentially just a directory that contains some code files. | |||
There was a problem hiding this comment.
something messed up with the merge, but this actually came from a separate PR
|
/lgtm |
achals
approved these changes
Aug 2, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, adchia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Moves the feast CLI's apply method (
feast apply) to use the SDK FeatureStore class more. Note that because the feast CLI's apply is a total apply whereas the SDK apply is partial, there is still leftover business logic (in particular for deleting entities / FVs that don't match the repo).Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?: