Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the types test to run on all compatible environments #1840

Merged
merged 3 commits into from
Sep 5, 2021

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Sep 5, 2021

What this PR does / why we need it:
Enables the types test to test feature types across compatible offline / online stores (but e.g. not using list features on Redshift since Redshift doesn't support those). This also doesn't fully enable testing materializing list features for BQ because of #1839.

This also fixes some missing teardown functionality, which caused tests to fail because the same "project" across different environments that used the same offline store caused issues (e.g. inability to create a new dataset)

This surfaced a bug where we can't materialize list features in BQ. There's a J
Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2021

Codecov Report

Merging #1840 (4c5caf8) into master (09e0955) will increase coverage by 0.12%.
The diff coverage is 97.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1840      +/-   ##
==========================================
+ Coverage   84.32%   84.45%   +0.12%     
==========================================
  Files          93       90       -3     
  Lines        6869     6772      -97     
==========================================
- Hits         5792     5719      -73     
+ Misses       1077     1053      -24     
Flag Coverage Δ
integrationtests 84.37% <97.91%> (+0.12%) ⬆️
unittests 63.73% <37.50%> (+0.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/tests/conftest.py 100.00% <ø> (+3.70%) ⬆️
sdk/python/feast/infra/online_stores/sqlite.py 96.51% <50.00%> (-2.29%) ⬇️
...n/feature_repos/universal/data_sources/bigquery.py 97.67% <100.00%> (+0.05%) ⬆️
...s/integration/registration/test_universal_types.py 100.00% <100.00%> (ø)
sdk/python/feast/infra/online_stores/redis.py 92.85% <0.00%> (-1.79%) ⬇️
sdk/python/feast/registry.py 78.83% <0.00%> (-1.06%) ⬇️
...ts/integration/feature_repos/repo_configuration.py 100.00% <0.00%> (ø)
.../integration/online_store/test_universal_online.py 100.00% <0.00%> (ø)
...fline_store/test_universal_historical_retrieval.py 100.00% <0.00%> (ø)
...hon/tests/integration/registration/test_cli_gcp.py
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09e0955...4c5caf8. Read the comment docs.

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit fd255ca into feast-dev:master Sep 5, 2021
@adchia adchia deleted the moreTypes branch September 15, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants