Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable the types test to run on all compatible environments #1840

Merged
merged 3 commits into from
Sep 5, 2021
Merged

Enable the types test to run on all compatible environments #1840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
91161a5
Adding fixtures for type test
adchia Sep 3, 2021
f53c57c
Refactor to use fixtures
adchia Sep 5, 2021
4c5caf8
Add issue on github
adchia Sep 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion sdk/python/feast/infra/online_stores/sqlite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,10 @@ def teardown(
tables: Sequence[Union[FeatureTable, FeatureView]],
entities: Sequence[Entity],
):
os.unlink(self._get_db_path(config))
try:
os.unlink(self._get_db_path(config))
except FileNotFoundError:
pass


def _table_id(project: str, table: Union[FeatureTable, FeatureView]) -> str:
Expand Down
6 changes: 0 additions & 6 deletions sdk/python/tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,9 +132,3 @@ def e2e_data_sources(environment: Environment):
yield df, data_source

environment.data_source_creator.teardown()


@pytest.fixture(params=FULL_REPO_CONFIGS, scope="session")
def type_test_environment(request):
with construct_test_environment(request.param) as e:
yield e
1 change: 1 addition & 0 deletions sdk/python/tests/integration/feature_repos/universal/data_sources/bigquery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ def teardown(self):
self.dataset_id, delete_contents=True, not_found_ok=True
)
print(f"Deleted dataset '{self.dataset_id}'")
self.dataset = None

def create_offline_store_config(self):
return BigQueryOfflineStoreConfig()
Expand Down
Loading