Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README to reflect new integration test suites #2124

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Dec 8, 2021

What this PR does / why we need it:
We have new java integration tests as well as a new workflow file for the existing integration tests / continuous build. This updates the workflow names and READMEs to reflect these changes.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

…he java master only badge and adding to the README

Signed-off-by: Danny Chiao <danny@tecton.ai>
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2021

Codecov Report

Merging #2124 (eb3a05c) into master (65c41bd) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2124      +/-   ##
==========================================
+ Coverage   83.45%   83.51%   +0.06%     
==========================================
  Files         100      100              
  Lines        8088     8088              
==========================================
+ Hits         6750     6755       +5     
+ Misses       1338     1333       -5     
Flag Coverage Δ
integrationtests 73.94% <ø> (+0.04%) ⬆️
unittests 57.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/utils/aws_utils.py 84.78% <0.00%> (+1.44%) ⬆️
sdk/python/feast/infra/online_stores/datastore.py 93.70% <0.00%> (+2.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65c41bd...eb3a05c. Read the comment docs.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex
Copy link
Collaborator

pyalex commented Dec 8, 2021

/lgtm

@feast-ci-bot feast-ci-bot merged commit 11e62f0 into feast-dev:master Dec 8, 2021
adchia added a commit that referenced this pull request Dec 11, 2021
…he java master only badge and adding to the README (#2124)

Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia adchia deleted the fixReadme branch March 4, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants