Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Projects optional & Update Feature References #693

Merged
merged 21 commits into from
May 19, 2020
Merged

Make Projects optional & Update Feature References #693

merged 21 commits into from
May 19, 2020

Commits on May 18, 2020

  1. Squash and rebase on master 

    Squashed commits:
* Update e2e test verify that users can retrieve from multiple featuresets in batch serving
* Add e2e test verify that users can retrieve from multiple featuresets in online serving
* Remove and Reserve version field in FeatureReference in ServingService proto
* Clarify comment in SpecService docs
* Update BQ Retriever to only namespace returned features with featureset only when explictly specified in feature reference.
* Configure BQ Retriever SQL queries to namespace returned feature column with feature set name
* Resolve unresolved rebase markers in Python's SDK client docs
* Squash and Rebase on master
* history:
* Fix batch e2e failing as new SDK does not accept feature refs with projects.
* Fix e2e batch tests: remove rebase markers
* Fix keyerror in end to end tests
* Fix e2e test that still has removed versions
* Correct spelling of omitted in SpecService
* Squash and rebase on version removal PR
* Fix java lint
* Remove comments in JobServiceTest that do not comply with JavaDoc
* Clarify naming of unit test in SpecServiceTest
* Fix python linting
* Refactor AccessManagementService's archiveProject() to use guard clauses
* Update Go SDK to strip the project part of string feature references returned from serving
* Update Java SDK to strip the project part of string feature references returned from serving
* Update Python SDK to strip the project part of string feature references returned from serving
* Fix java unit tests afeter adding check for duplicate feature references
* Remove trailing whitespace to satisfy python lint.
* Fix typo in e2e
* Add check that multiple feature references in get online/batch features don't refer to the same feature
* Fix end to end tests referencing the same feature in different references
* Fix typo in call to get_feature_set in e2e tests.
* Fix issue in e2e test where client persisted wrong project. Should used default instead.
* Remove support of projects in string Feature References in java SDK
* Remove support of projects in string Feature References in go SDK
* Remove support of projects in string Feature References in python SDK
* Fix python SDK linting failures
* Update documentation in CoreService proto to document that field names are unique with a featureset
* Update E2E tests to check default project and updated feature reference functionality
* Fixed Python SDK's FeatureSetRef rendering with missing project
* Make Python's SDK client's archive_project() revert to default project on archive.
* Make Feast Core throw an error when the user attempts to archive the default project
* Apply spotless formatting to java SDK's RequestUtil
* Updated python SDK's client's to parse feature refs without projects and with feature sets
* Update Go SDK buildFeatureRefs() to parse feature refs without projects and with feature sets
* Regenrate go protos for Go SDK using make compile-protos-go
* Changes Java SDK's FeastClient defaultProject to project which overrides project in feature refs.
* Updated Java SDK's RequestUtil to parse string feature refs without project/with feature set.
* Refactor CachedSpecService to support different variations of feature references.
* Update RefUtil's generateFeatureStringRef to FeatureReference with featureset name field
* Add missing final to make core Project models's DEFAULT_NAME into a constant.
* Added feature_set_name field to ServingService's FeatureReference proto
* Remove projects from JobUpdateTask's unit tests
* Remove projects from ServingServiceGRpcControllerTest's unit tests.
* Remove projects from OnlineServingService's unit tests.
* Update CachedSpecService's getFeatureToFeatureSetMapping() to match Feature References with no project.
* Update RefUtil's generateFeatureStringRef() to properly render refs without a project
* Document in CoreService proto that specifying project in list, get, update featureset is optional
* Update SpecService's applyFeatureSet() to auto default project if not specified.
* Update SpecService's listFeatureSets() to autofill default project if project unspecified.
* Remove comment as FeatureSet's id is no longer a String.
* Update SpecService's getFeatureSet() to autofill default project if project unspecified.
* Config AccessManagementService to create default project in constructor
* Document that FeatureReference's project field is optional.
* Allow CachedSpecService's getFeatureSets() to match FeatureReferences with no project by autofilling default project
* Make CachedSpecService's featureSetCacheLoader a local var instead of private property as its only used once.
    Zhu Zhanyan committed May 18, 2020
    Configuration menu
    Copy the full SHA
    6a61582 View commit details
    Browse the repository at this point in the history

  2. Change SpecServiceTest to use global default project constant.

    Zhu Zhanyan committed May 18, 2020
    Configuration menu
    Copy the full SHA
    4b694d5 View commit details
    Browse the repository at this point in the history

  3. Make AccessManagementService's archiveProject() throw UnimplementOper… 

    …ation error when trying to archive default project.
    Zhu Zhanyan committed May 18, 2020
    Configuration menu
    Copy the full SHA
    68b9482 View commit details
    Browse the repository at this point in the history

  4. Correct incorrect documentation on source being ignored on Core's App… 

    …lyFeatureSet
    Zhu Zhanyan committed May 18, 2020
    Configuration menu
    Copy the full SHA
    1d74ce5 View commit details
    Browse the repository at this point in the history

  5. Use ValueProto.Value in java SDK's FeastClient lambda instead of gene… 

    …ric Object
    Zhu Zhanyan committed May 18, 2020
    Configuration menu
    Copy the full SHA
    179819a View commit details
    Browse the repository at this point in the history

  6. Clarify how the ignore project param of feature ref to string() worke… 

    …d in docs in SDKs
    Zhu Zhanyan committed May 18, 2020
    Configuration menu
    Copy the full SHA
    78c5fdd View commit details
    Browse the repository at this point in the history

  7. Correct missing test to check for empty feature refs in java SDK.

    Zhu Zhanyan committed May 18, 2020
    Configuration menu
    Copy the full SHA
    e9befcf View commit details
    Browse the repository at this point in the history

  8. Clarified ref_protos to feature_ref_protos to make code clearer

    Zhu Zhanyan committed May 18, 2020
    Configuration menu
    Copy the full SHA
    dce338d View commit details
    Browse the repository at this point in the history

  9. Rename ServingService's FeatureReference proto 'feature_set_name` to … 

    …`feature_set`
    Zhu Zhanyan committed May 18, 2020
    Configuration menu
    Copy the full SHA
    88cae23 View commit details
    Browse the repository at this point in the history

  10. Remove nested function strip_project() with loop with python SDK's cl… 

    …ient's get_online_features()
    Zhu Zhanyan committed May 18, 2020
    Configuration menu
    Copy the full SHA
    e67abab View commit details
    Browse the repository at this point in the history

  11. Remove extra version paramter in python sdk test's TestFeatureRef

    Zhu Zhanyan committed May 18, 2020
    Configuration menu
    Copy the full SHA
    96b5fed View commit details
    Browse the repository at this point in the history

  12. Change CachedSpecService's "hasProject == true" to more concise "!has… 

    …Project"
    Zhu Zhanyan committed May 18, 2020
    Configuration menu
    Copy the full SHA
    11d1c31 View commit details
    Browse the repository at this point in the history

  13. Removed setFeatureSet() calls to OnlineServingServiceTest as it does … 

    …not need to be set in the unit test
    Zhu Zhanyan committed May 18, 2020
    Configuration menu
    Copy the full SHA
    0aaf56e View commit details
    Browse the repository at this point in the history

  14. Make client.set_project() without args reset project to default in py… 

    …thon SDK
    Zhu Zhanyan committed May 18, 2020
    Configuration menu
    Copy the full SHA
    ab9cdc6 View commit details
    Browse the repository at this point in the history

  15. Updated e2e to test for feature set inference for feature ref without… 

    … feature set specified
    Zhu Zhanyan committed May 18, 2020
    Configuration menu
    Copy the full SHA
    6bfcccb View commit details
    Browse the repository at this point in the history

  16. Remove unused field max_age in FeatureReference

    Zhu Zhanyan committed May 18, 2020
    Configuration menu
    Copy the full SHA
    12c7087 View commit details
    Browse the repository at this point in the history

  17. Fix typo in e2e

    Zhu Zhanyan committed May 18, 2020
    Configuration menu
    Copy the full SHA
    19d1f8a View commit details
    Browse the repository at this point in the history

  18. Fix error in e2e tests regarding string splits

    Zhu Zhanyan committed May 18, 2020
    Configuration menu
    Copy the full SHA
    713b5bd View commit details
    Browse the repository at this point in the history

  19. Optimise Serving's CachedSpecService populateCache() by directly assi… 

    …gning map.
    Zhu Zhanyan committed May 18, 2020
    Configuration menu
    Copy the full SHA
    15ac15e View commit details
    Browse the repository at this point in the history

  20. Remove final in CachedSpecService to allow assignment in featureToFea… 

    …tureSetMapping
    Zhu Zhanyan committed May 18, 2020
    Configuration menu
    Copy the full SHA
    dbfec8d View commit details
    Browse the repository at this point in the history

  21. Remove unnescessary copy of list in QueryTemplater

    Zhu Zhanyan committed May 18, 2020
    Configuration menu
    Copy the full SHA
    adeb743 View commit details
    Browse the repository at this point in the history