-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Projects optional & Update Feature References #693
Make Projects optional & Update Feature References #693
Conversation
core/src/main/java/feast/core/service/AccessManagementService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do a more thorough review once this has been rebased on top of version removal, since the code would be significantly easier to digest than in its current state.
/test test-end-to-end-batch |
/test test-end-to-end-redis-cluster |
/retest |
1 similar comment
/retest |
/test test-end-to-end |
/test test-end-to-end-redis-cluster |
if (request.getProject().isEmpty()) { | ||
throw new IllegalArgumentException("No project provided"); | ||
request = request.toBuilder().setProject("default").build(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be using one global project constant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected.
…ient's get_online_features()
…not need to be set in the unit test
… feature set specified
storage/connectors/bigquery/src/main/resources/templates/join_featuresets.sql
Show resolved
Hide resolved
...ctors/bigquery/src/main/java/feast/storage/connectors/bigquery/retriever/QueryTemplater.java
Outdated
Show resolved
Hide resolved
/test test-end-to-end-batch |
/test test-end-to-end-batch |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrzzy, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What this PR does / why we need it:
Makes Projects optional by introducing a default project
default
:default
project.default
project would be used where users do not explicit specify a project in CoreService'slistFeatureSets(), getFeatureSet(), applyFeatureSet()
.default
projects. Theproject
field is now optional.Update Feature References to support duplicate Features names within project but unique within Feature Set:
feature_set
field to FeatureReference proto.[project/][feature_set:]feature_name
with Feast Servingproject
, and /orfeature_set_name
. If multiple features match, returns an error to mark the ambiguity.Update Feast Go, Java, Python SDKs to transition to string Feature References without Projects:
Which issue(s) this PR fixes:
Fixes #631
Does this PR introduce a user-facing change?: