Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply default project to rows without project during ingestion #701

Merged
merged 3 commits into from
May 19, 2020

Conversation

zhilingc
Copy link
Collaborator

What this PR does / why we need it:

Extension to #693. Feast Core deploys Feast ingestion jobs with a parameter that sets its default project. This default project is just a string (using “default” for now).

When a FeatureRow is read from Kafka with with a complete feature set reference (project/feature_set) then it is processed as normal. However, when a FeatureRow is read in with a feature set reference missing project (just featureset), then Feast Ingestion prepends the default project string to this reference.

Does this PR introduce a user-facing change?:

Feature rows can be ingested with just the feature set name. Feast core will apply the default project to those feature rows.

@woop
Copy link
Member

woop commented May 18, 2020

/lgtm

@feast-ci-bot feast-ci-bot added lgtm and removed lgtm labels May 18, 2020
@woop woop added lgtm and removed lgtm labels May 18, 2020
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: woop, zhilingc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit d8459e0 into feast-dev:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants