Skip to content

Commit

Permalink
refactor!: init dove (#691)
Browse files Browse the repository at this point in the history
* Updated @feathersjs dependencies to ^5.0.0-pre.3

* Added @feathersjs/adapter-commons to import `Paginated`

* Updated Typescript to 4.2.4

* Set minimum Typescript to 4.0 for dslint

* Re-import Paginated

* Updated `combine` to work with Dove

Re-implemented `processHooks` inside, since that’s all it was calling.

* Updated dslint tests - all project tests passing

Changed `feathers` import
Added required properties for `HookContext`
Updated typeexpectations for dslint since `Hook` is now an alias

* Updated @feathersjs dependencies to ^5.0.0-pre.4

* Re-import Paginated

* Removed @feathersjs/adapter-commons from dependencies

* Updated @feathersjs dependencies to ^5.0.0-pre.9

All tests passing

* refactor!: move to feathers v5

* chore: update package-lock

* fix: use generics for hooks
- @see docs link
- correct utils docs link
- export * from
- move types to individual files
- use prettier

* refactor: move to generic HookContext

* refactor: make tests run again

* refactor: pass tests

* chore: add prettier

Co-authored-by: Jesse Cox <jesse@apprhythmia.com>
  • Loading branch information
fratzinger and forgot authored Sep 27, 2022
1 parent c5bf8cd commit c808c9b
Show file tree
Hide file tree
Showing 125 changed files with 6,984 additions and 6,230 deletions.
41 changes: 10 additions & 31 deletions .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
},
"extends": [
"plugin:@typescript-eslint/recommended",
"plugin:@typescript-eslint/recommended-requiring-type-checking"
"plugin:@typescript-eslint/recommended-requiring-type-checking",
"plugin:prettier/recommended"
],
"parser": "@typescript-eslint/parser",
"parserOptions": {
Expand All @@ -17,10 +18,11 @@
"plugins": [
"eslint-plugin-import",
"eslint-plugin-prefer-arrow",
"@typescript-eslint"
"@typescript-eslint",
"prettier"
],
"rules": {
"indent": ["warn", 2],
// "indent": ["warn", 2],
"prefer-rest-params": "off",
"prefer-spread": "off",
"@typescript-eslint/no-unsafe-member-access": "off",
Expand Down Expand Up @@ -52,7 +54,7 @@
"@typescript-eslint/explicit-member-accessibility": [
"error",
{
"accessibility": "no-public"
"accessibility": "no-public"
}
],
"@typescript-eslint/naming-convention": "off",
Expand All @@ -68,10 +70,6 @@
"@typescript-eslint/prefer-for-of": "error",
"@typescript-eslint/prefer-function-type": "error",
"@typescript-eslint/prefer-namespace-keyword": "error",
"@typescript-eslint/quotes": [
"error",
"single"
],
"@typescript-eslint/triple-slash-reference": [
"error",
{
Expand All @@ -82,28 +80,16 @@
],
"@typescript-eslint/unified-signatures": "error",
"@typescript-eslint/consistent-type-imports": ["warn", { "prefer": "type-imports" }],
"@typescript-eslint/object-curly-spacing": ["warn", "always"],
"arrow-parens": [
"off",
"always"
],
"comma-dangle": "error",
"arrow-parens": ["off", "always"],
"complexity": "off",
"constructor-super": "error",
"eqeqeq": [
"error",
"smart"
],
"eqeqeq": ["error", "smart"],
"guard-for-in": "error",
"id-blacklist": "off",
"id-match": "off",
"import/order": "off",
// "jsdoc/check-alignment": "error",
// "jsdoc/check-indentation": "error",
// "jsdoc/newline-after-description": "error",
"max-classes-per-file": "off",
"max-len": "off",
"new-parens": "error",
"no-bitwise": "error",
"no-caller": "error",
"no-cond-assign": "error",
Expand All @@ -121,28 +107,21 @@
}
],
"no-throw-literal": "error",
"no-trailing-spaces": "error",
"no-undef-init": "error",
"no-underscore-dangle": "off",
"no-unsafe-finally": "error",
"no-unused-labels": "error",
"no-var": "error",
"object-shorthand": "error",
"one-var": [
"error",
"never"
],
"one-var": ["error", "never"],
"prefer-arrow/prefer-arrow-functions": "off",
"prefer-const": "error",
"radix": "error",
"space-before-function-paren": "error",
"spaced-comment": [
"error",
"always",
{
"markers": [
"/"
]
"markers": ["/"]
}
],
"use-isnan": "error",
Expand Down
11 changes: 11 additions & 0 deletions .prettierrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"$schema": "http://json.schemastore.org/prettierrc",
"arrowParens": "avoid",
"bracketSpacing": true,
"printWidth": 100,
"semi": true,
"singleQuote": true,
"tabWidth": 2,
"bracketSameLine": false,
"htmlWhitespaceSensitivity": "ignore"
}
Loading

0 comments on commit c808c9b

Please sign in to comment.