-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: init dove #691
Merged
Merged
refactor!: init dove #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-implemented `processHooks` inside, since that’s all it was calling.
Changed `feathers` import Added required properties for `HookContext` Updated typeexpectations for dslint since `Hook` is now an alias
# Conflicts: # package-lock.json # package.json
Pull in all upstream changes
All tests passing
- @see docs link - correct utils docs link - export * from - move types to individual files - use prettier
fratzinger
added a commit
that referenced
this pull request
Feb 24, 2023
* refactor!: init dove (#691) * Updated @feathersjs dependencies to ^5.0.0-pre.3 * Added @feathersjs/adapter-commons to import `Paginated` * Updated Typescript to 4.2.4 * Set minimum Typescript to 4.0 for dslint * Re-import Paginated * Updated `combine` to work with Dove Re-implemented `processHooks` inside, since that’s all it was calling. * Updated dslint tests - all project tests passing Changed `feathers` import Added required properties for `HookContext` Updated typeexpectations for dslint since `Hook` is now an alias * Updated @feathersjs dependencies to ^5.0.0-pre.4 * Re-import Paginated * Removed @feathersjs/adapter-commons from dependencies * Updated @feathersjs dependencies to ^5.0.0-pre.9 All tests passing * refactor!: move to feathers v5 * chore: update package-lock * fix: use generics for hooks - @see docs link - correct utils docs link - export * from - move types to individual files - use prettier * refactor: move to generic HookContext * refactor: make tests run again * refactor: pass tests * chore: add prettier Co-authored-by: Jesse Cox <jesse@apprhythmia.com> * chore: add premajor script * 7.0.0-pre.0 * Updating changelog * fix: use generic for iff predicate * 7.0.0-pre.1 * Updating changelog * chore: update dependencies * chore: update dependencies * 7.0.0-pre.2 * Updating changelog * chore: update dependencies * chore: update dependencies --------- Co-authored-by: Jesse Cox <jesse@apprhythmia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @forgot for the initial work! Finally we have an official dove branch/version.
Releasing this as
pre
-version. Closing #623 in favor of this.Thanks again @forgot!