-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dove Support #623
Dove Support #623
Conversation
Re-implemented `processHooks` inside, since that’s all it was calling.
Changed `feathers` import Added required properties for `HookContext` Updated typeexpectations for dslint since `Hook` is now an alias
This is also great, thank you! Probably needs the same |
I've bumped everything to |
# Conflicts: # package-lock.json # package.json
Pull in all upstream changes
All tests passing
I've bumped everything to 5.0.0-pre.9, and all tests are still passing. I'm guessing all of these will need to be migrated to the new format with backwards compatibility before this is of any real use in Dove. |
I wonder what the best approach would be here. Should all hooks be updated to the new format and provide backwards compatible I'm also wondering if this might be a good time to look at things that can be improved using the new hooks or consolidated. For example, many common hooks for string casing and array processing could just be wrappers for standard Lodash and I think there is also some overlap with @DaddyWarbucks great feathers-fletching. |
Could we have a pre-release of this? |
I believe the latest release should work. Does it not? |
I want to update my libraries (feathers-casl and feathers-utils) to feathers@5. Screenshot shows type differences between |
Closing in favor of #691. Thanks for your work! |
Updates
@feathersjs
dependencies to^5.0.0-pre.3
to work with DoveNot that I could find...
Nope!
This pull request primarily updates the type expectations to match Dove. Due to the removal of the
processHooks
function, thecombine
hook had to be reimplemented. It would obviously be better if this remained it's own branch and did not merge withmaster
, but I'm not sure how to create a pull request that does that.All tests pass with
npm test