-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
port to ts #654
port to ts #654
Conversation
Co-authored-by: ts-migrate <>
Co-authored-by: ts-migrate <>
Co-authored-by: ts-migrate <>
Amazing! I wonder how many things for this would break/change with the latest v5. It does have a good chunk of TypeScript related changes - especially around the hook context. |
- `existsByDot` and `data[name]` do basically the same. So `data[name]` is unnecessary
I don't know yet. I'm definitely up to work on that. But I think we could merge this first. What do you think @daffl? Also with #623 . What's the best strategy? Possible strategies:
However the strategy will be, I would love to work on open PR to clean up the repo:
|
We can totally merge this one first once you put it into the ready for review state. |
It's ready 😊 |
continuing on #663 |
Move the code base to typescript. Just a refactor, nothing should break but imports from
require(feathers-hooks-common/lib/...)
orrequire(feathers-hooks-common/types)
We should make it a major version, just to be sure.
What do you think @daffl ?
Issues: closes #656
PRs: closes #662, #646, #634