6316 National Party Datatables Cycles Selector Limits

[rfultz]

Summary

• Resolves Add date constraints to help clarify the availability of data across time #6316

Adding optional date constraints for the cycles selector, like we have for the years selector

Required reviewers

• UX
• front-end?

Impacted areas of the application

The cycle selector for the national party datatables but maybe every other cycle selector, too

Screenshots

Related PRs

nah

How to test

• Pull the branch
• npm i
• npm run build
• ./manage.py runserver
• Check the national party disbursements datatable cycle filter
• Check the national party receipts datatable cycle filter
• Check other datatables cycle filters (unlikely to have been affected)

[JonellaCulmer]

Having trouble with my local (what else is new?) but if both dropdowns go to 2013-2014 cycle then I'm good. Can't tell from the screenshot.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.54%. Comparing base (f80ecee) to head (9502ffd).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #6407   +/-   ##
========================================
  Coverage    80.54%   80.54%           
========================================
  Files          233      233           
  Lines         5042     5042           
========================================
  Hits          4061     4061           
  Misses         981      981           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[patphongs]

👍

[JonellaCulmer]

Everything looks great. Thanks so much for your work on this @rfultz