Add validation to sorting option #5509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcaofec
changed the title
|
@hcaofec The following endpoints are throwing 422 error. Could you include Party, State, District, Name, Receipts and Disbursements columns as sortable fields? Presidential Candidates: Senate candidates: House of representatives: |
hcaofec
force-pushed
the
feature/5479-status-code-for-invalid-sort-option
branch
from
276b775 to
7132dc9
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5509 +/- ##
========================================
Coverage 85.50% 85.50%
========================================
Files 81 81
Lines 8173 8174 +1
========================================
+ Hits 6988 6989 +1
Misses 1185 1185
|
pkfec
approved these changes
Jul 31, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary (required)
Limit sortable fields to: ['election_year', 'cycle', 'state', 'office']. Add validation to sortable fields, and set status code to 422 when invalid sorting field is selected.
Required reviewers
1 developer
How to test
pytestflask runto start api on local and test these endpoints:sort = -test
http://127.0.0.1:5000/v1/candidates/totals/?page=1&per_page=20&election_full=true&sort=-test&sort_hide_null=false&sort_null_only=false&sort_nulls_last=false
sort = -election_year
http://127.0.0.1:5000/v1/candidates/totals/?page=1&per_page=20&election_full=true&sort=-election_year&sort_hide_null=false&sort_null_only=false&sort_nulls_last=false