Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation to sorting option #5509

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Add validation to sorting option #5509

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion webservices/resources/candidate_aggregates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,9 +160,27 @@ class TotalsCandidateView(ApiResource):
schema = schemas.CandidateHistoryTotalSchema
page_schema = schemas.CandidateHistoryTotalPageSchema

sort_options = [
'election_year',
'name',
'party',
'state',
'office',
'district',
'receipts',
'disbursements',
]

@property
def args(self):
return utils.extend(args.paging, args.candidate_totals, args.make_sort_args(),)
return utils.extend(
args.paging,
args.candidate_totals,
args.make_sort_args(
default='-election_year',
validator=args.OptionValidator(self.sort_options)
),
)

def filter_multi_fields(self, history, total):
return [
Expand Down