Add national party schedule a/b endpoints

[pkfec]

Summary

Create two new national party account endpoints (Transaction level) under swagger docs

1. /national_party/schedule_a/
2. /national_party/schedule_b/

Resolves #5786

Related #5811

Required reviewers

1 frontend and 2 or more backend developers

Screenshots

How to test

On local:

• run git checkout feature/nation-party-endpoints

• run pyenv activate venv-api

• run pip install -r requirements.txt

• run pip install -r requirements-dev.txt

• run pytest

• run flask run

• test filters under national_party/schedule_a endpoint:
  http://127.0.0.1:5000/v1/national_party/schedule_a/?page=1&per_page=20&sort=-contribution_receipt_date&sort_hide_null=false&sort_null_only=false

• test filters under national_party/schedule_b endpoint:
  http://127.0.0.1:5000/v1/national_party/schedule_b/?page=1&per_page=20&sort=-disbursement_date&sort_hide_null=false&sort_null_only=false

OR

Deploy a test branch to Dev space and test the NPA filters

[codecov]

Codecov Report

Attention: Patch coverage is 97.95918% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 86.18%. Comparing base (3e9f5b8) to head (ab254ab).
Report is 8 commits behind head on develop.

Files	Patch %	Lines
webservices/resources/national_party.py	91.04%	6 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #5791      +/-   ##
===========================================
+ Coverage    85.77%   86.18%   +0.41%     
===========================================
  Files           81       83       +2     
  Lines         8624     8918     +294     
===========================================
+ Hits          7397     7686     +289     
- Misses        1227     1232       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cnlucas]

Can we remove these null fields. I think ideally they wouldn't be in the MV, but can we at least take them out of the model? Can someone confirm what I'm seeing--that they all are null?
organization_type
organization_type_full
candidate_first_name
candidate_id
candidate_last_name
candidate_middle_name
candidate_name
candidate_office
candidate_office_district
candidate_office_full
candidate_office_state
candidate_office_state_full
conduit_committee_city
conduit_committee_id
conduit_committee_name
conduit_committee_state
conduit_committee_street1
conduit_committee_street2
conduit_committee_zip
candidate_prefix
candidate_suffix

[pkfec]

Can we remove these null fields. I think ideally they wouldn't be in the MV, but can we at least take them out of the model? Can someone confirm what I'm seeing--that they all are null? organization_type organization_type_full candidate_first_name candidate_id candidate_last_name candidate_middle_name candidate_name candidate_office candidate_office_district candidate_office_full candidate_office_state candidate_office_state_full conduit_committee_city conduit_committee_id conduit_committee_name conduit_committee_state conduit_committee_street1 conduit_committee_street2 conduit_committee_zip candidate_prefix candidate_suffix

Sure, I can take a look and confirm if all the fields are null.

[pkfec]

conduit_committee_city
conduit_committee_id
conduit_committee_name
conduit_committee_state
conduit_committee_street1
conduit_committee_street2
conduit_committee_zip

@PaulClark2 suggested removing the organization and conduit* fields since party committees typically lack that data. However, he recommended keeping the candidate information since some party committees do have relevant data for it.
cc @hcaofec

[pkfec]

conduit_committee_city
conduit_committee_id
conduit_committee_name
conduit_committee_state
conduit_committee_street1
conduit_committee_street2
conduit_committee_zip

@PaulClark2 suggested removing the organization and conduit* fields since party committees typically lack that data. However, he recommended keeping the candidate information since some party committees do have relevant data for it. cc @hcaofec

I removed the organization and conduit* fields from the NPA model file

[cnlucas]

Fabulous job @pkfec! Thank you so much!

[fec-jli]

It works as expected.
Could we consider creating a separate ticket to add a 'Zipcode' validation function in args.py? This would help eliminate the excessive duplication of Zipcode validation code in many places.

[pkfec]

It works as expected. Could we consider creating a separate ticket to add a 'Zipcode' validation function in args.py? This would help eliminate the excessive duplication of Zipcode validation code in many places.

Thanks for the feedback @fec-jli. I can make up a ticket to move the Zipcode validation function to webservies.utils.py instead of args.py as most of the validations happens in utils.py

[tmpayton]

Really awesome job @pkfec!

[hcaofec]

Great work!

[johnnyporkchops]

Endpoints look good . Great job Priya!

[pkfec]

I added recipient_zip as a filter for sb endpoint.

[JonellaCulmer]

@pkfec Just one thing for the endpoints:

• Change receipt_type and disbursement_type filter descriptions to say: "National party account receipt types:" or "National party account disbursement types:"

[pkfec]

@pkfec Just one thing for the endpoints:

• Change receipt_type and disbursement_type filter descriptions to say: "National party account receipt types:" or "National party account disbursement types:"

@JonellaCulmer I updated ^^ filter descriptions in docs.py

[JonellaCulmer]

This looks really great, @pkfec. Thanks for all your hard work on this.