Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MVs for national party accounts data #5811

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

hcaofec
Copy link
Contributor

@hcaofec hcaofec commented Apr 25, 2024

Summary (required)

Required reviewers

1-2 developers

How to test

  • Download feature branch and run pytest
  • Run flyway migrate

Copy link
Contributor

@pkfec pkfec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @hcaofec

Copy link
Contributor

@fecjjeng fecjjeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The migration files look good.

The branch had been downloaded to local machine and the following had been done:

  • flyway migrate
  • pytest
  • create_sample_db
    All completed successfully.

Good job!
PR approved.

@fecjjeng fecjjeng merged commit 555af67 into develop Apr 29, 2024
3 checks passed
@hcaofec hcaofec deleted the feature/5804-refactor-nat-party-mv branch May 23, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Refactor national party accounts MVs
3 participants