Set the QoS on the channel that is created for the consumer #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to [the RabbitMQ docs](https://www.rabbitmq.com/consumer-prefetch.html), they changed the semantics of the `global` QoS parameter, and setting it to `True` as we've done does not enforce the prefetch limit on all channels in the connection but rather on all consumers in the channel. There is no way to have connection-wide limits with RabbitMQ. Since we create a new channel for each consumer, we must set the QoS in this channel and not in the main channel, otherwise it'll always be limitless. Fixes fedora-infra#223 Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
Codecov Report
@@ Coverage Diff @@
## stable #224 +/- ##
=======================================
Coverage 95.68% 95.68%
=======================================
Files 13 13
Lines 1343 1344 +1
Branches 166 166
=======================================
+ Hits 1285 1286 +1
Misses 43 43
Partials 15 15
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the RabbitMQ docs, they changed the semantics of the
globalQoS parameter, and setting it toTrueas we've done does not enforce the prefetch limit on all channels in the connection but rather on all consumers in the channel. There is no way to have connection-wide limits with RabbitMQ.Since we create a new channel for each consumer, we must set the QoS in this channel and not in the main channel, otherwise it'll always be limitless.
Fixes #223