Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the QoS on the channel that is created for the consumer #224

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Set the QoS on the channel that is created for the consumer #224

merged 1 commit into from
Aug 4, 2020

Commits on Jul 29, 2020

  1. Set the QoS on the channel that is created for the consumer 

    According to [the RabbitMQ
docs](https://www.rabbitmq.com/consumer-prefetch.html), they changed the
semantics of the `global` QoS parameter, and setting it to `True` as
we've done does not enforce the prefetch limit on all channels in the
connection but rather on all consumers in the channel. There is no way
to have connection-wide limits with RabbitMQ.

Since we create a new channel for each consumer, we must set the QoS in
this channel and not in the main channel, otherwise it'll always be
limitless.

Fixes fedora-infra#223

Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
    @abompard
    abompard committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    44417a5 View commit details
    Browse the repository at this point in the history