fix: macos-notification-state not working well #1794
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
com.apple.developer.usernotifications.communication
to allow the app to use the focus state on MacOS properly.macos-notification-state
module, which prevented building locally on Linux and gave an error on Windows.Motivation and Context
It seems that we have been missing a key element in the entitlement file in order to allow Focus State to work on MacOS without granting full rights on the disk to Ferdium.
Also, when building locally on Linux or Windows, the typecheck happening on the
dnd.ts
file fails since the module is not loaded. Adding these comments to avoid problems in the same vein that we do withnode-mac-permissions
there:ferdium-app/src/electron/macOSPermissions.ts
Lines 5 to 7 in 6f84b89
Important note: I have not tested whether this completely works since my mac does not support Monterrey and above, but currently, it seems to be the last missing piece of the puzzle.
This possibly resolves the following:
Fixes #1047
Fixes #798
Checklist
pnpm prepare-code
)pnpm test
passesRelease Notes