Partially revert "fix: macos-notification-state not working well" #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f1790ac.
Alphrag
force-pushed
the
revert-1794-macos-notification
branch
from
5b61b3f
to
6021d29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts change of entitlements files from #1794
Fixes #1797
Description of explaination
It seems that the added entitlement prevents the app from being run after notarization. Even though the app is deemed as correctly signed and notarize, the user will see a prompt saying:
"You do not possess the authorisations needed to open this app. Please contact your administrator to obtain further assistance".
I do not know at the moment why this is the case, and will investigate this further, but as @vraravam mentioned when running tests, this does not happen on local builds, and may not even be necessary to make the FocusState work as expected.