Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken build by partially reverting prev commit #1928

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Fix broken build by partially reverting prev commit #1928

merged 1 commit into from
Oct 14, 2024

Conversation

vraravam
Copy link
Contributor

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

Revert prev commit since the app crashed on mac m1 upon startup with an existing profile

Motivation and Context

Fix app startup issue

Screenshots

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (pnpm prepare-code)
  • pnpm test passes
  • I tested/previewed my changes locally

Release Notes

@vraravam vraravam requested a review from Alphrag October 14, 2024 18:13
@vraravam vraravam self-assigned this Oct 14, 2024
@Alphrag
Copy link
Member

Alphrag commented Oct 14, 2024

Thanks for working on that fix!

@Alphrag Alphrag merged commit 162a40a into ferdium:develop Oct 14, 2024
5 checks passed
@Alphrag Alphrag mentioned this pull request Oct 14, 2024
Closed
@vraravam vraravam deleted the revert-builder branch October 15, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alphrag Alphrag Alphrag approved these changes

Assignees

@vraravam vraravam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vraravam @Alphrag