Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken build by partially reverting prev commit #1928

Merged
merged 1 commit into from
Oct 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build-helpers/notarize.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ exports.default = async function notarizing(context) {
const { notarize } = require('@electron/notarize');

await notarize({
tool: 'notarytool',
appPath: `${appOutDir}/${appName}.app`,
teamId: process.env.APPLE_TEAM_ID || '',
appleId: process.env.APPLEID || '',
Expand Down
5 changes: 2 additions & 3 deletions electron-builder.yml
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,8 @@ win:
arch: [x64, ia32, arm64]
- target: portable
arch: [x64, ia32, arm64]
signtoolOptions:
# The name of the CN appearing in the certificate must be present in the publisherName list below
publisherName: ["Ferdium Contributors", "Ambroise Grau"]
# The name of the CN appearing in the certificate must be present in the publisherName list below
publisherName: ["Ferdium Contributors", "Ambroise Grau"]
# Remove the verification for a signature to allow auto-update without signed certificate
verifyUpdateCodeSignature: false

Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
"electron-dl": "3.5.2",
"electron-find": "1.0.7",
"electron-react-titlebar": "1.2.1",
"electron-updater": "6.4.0-alpha.0",
"electron-updater": "6.3.9",
"electron-window-state": "5.0.3",
"fast-folder-size": "2.2.0",
"fs-extra": "11.2.0",
Expand Down Expand Up @@ -164,7 +164,7 @@
"concurrently": "8.2.2",
"cross-env": "7.0.3",
"electron": "32.2.0",
"electron-builder": "26.0.0-alpha.1",
"electron-builder": "24.13.3",
"esbuild": "0.16.17",
"esbuild-plugin-copy": "2.1.1",
"esbuild-runner": "2.2.2",
Expand Down
Loading
Loading