Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AEA-1189 Fixes to Crypto plugin PR #2112 #2291

Merged
merged 27 commits into from
Feb 24, 2021
Merged

Conversation

marcofavorito
Copy link
Contributor

@marcofavorito marcofavorito commented Feb 23, 2021

Proposed changes

This PR includes several improvements wrt #2112 .

Fixes

n/a

Types of changes

What types of changes does your code introduce to agents-aea?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease.
  • I have checked that the documentation about the aea cli tool works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

n/a

@marcofavorito marcofavorito marked this pull request as draft February 23, 2021 13:29
marcofavorito and others added 2 commits February 23, 2021 15:08
Co-authored-by: David Minarsch <david.minarsch@googlemail.com>
@codecov-io
Copy link

codecov-io commented Feb 23, 2021

Codecov Report

Merging #2291 (5a96041) into develop (d84735a) will decrease coverage by 0.54%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2291      +/-   ##
===========================================
- Coverage   100.00%   99.45%   -0.55%     
===========================================
  Files          297      420     +123     
  Lines        23293    30653    +7360     
===========================================
+ Hits         23293    30487    +7194     
- Misses           0      166     +166     
Flag Coverage Δ
unittests 99.45% <100.00%> (-0.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aea/test_tools/test_cases.py 100.00% <ø> (ø)
aea/cli/utils/context.py 100.00% <100.00%> (ø)
aea/configurations/base.py 100.00% <100.00%> (ø)
aea/skills/__init__.py 100.00% <0.00%> (ø)
...ckages/fetchai/skills/confirmation_aw2/strategy.py 100.00% <0.00%> (ø)
packages/fetchai/skills/tac_participation/game.py 100.00% <0.00%> (ø)
...ackages/fetchai/skills/generic_buyer/behaviours.py 100.00% <0.00%> (ø)
...kages/fetchai/skills/confirmation_aw1/dialogues.py 100.00% <0.00%> (ø)
.../fetchai/skills/simple_service_search/dialogues.py 100.00% <0.00%> (ø)
...ea-crypto-ethereum/aea_crypto_ethereum/ethereum.py 97.79% <0.00%> (ø)
... and 116 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d84735a...5a96041. Read the comment docs.

first version of ledger-integration page expanded with crypto plugin explanation.
marcofavorito and others added 3 commits February 23, 2021 20:55
- add instructions regarding the 'dependencies' field in 'aea-config.yaml';
- add instructions regarding crypto plug-ins.
@marcofavorito marcofavorito marked this pull request as ready for review February 24, 2021 08:56
@DavidMinarsch DavidMinarsch changed the title Fixes to Crypto plugin PR #2112 AEA-1189 Fixes to Crypto plugin PR #2112 Feb 24, 2021
Copy link
Contributor

@DavidMinarsch DavidMinarsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DavidMinarsch DavidMinarsch merged commit d649280 into develop Feb 24, 2021
@DavidMinarsch DavidMinarsch deleted the fix/crypto-plugin branch February 25, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants