Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Workflow Window/BoundaryDetector raises exception #753

Closed
2 of 3 tasks
detlefarend opened this issue May 20, 2023 · 6 comments · Fixed by #710
Closed
2 of 3 tasks

Bug: Workflow Window/BoundaryDetector raises exception #753

detlefarend opened this issue May 20, 2023 · 6 comments · Fixed by #710
Assignees
Labels
bug Something isn't working OA Online adaptivitiy

Comments

@detlefarend
Copy link
Member

detlefarend commented May 20, 2023

1 Describe the bug
I extended all howtos with task combination window+boundary detector as follows: I registered the _adapt_on_event method of the bd on the window for event Window.C_EVENT_DATA_REMOVED. Since then, the howtos

  • howto_oa_pp_004_rearranger_window_bd_normminmax_3d.py
  • howto_oa_pp_005_rearranger_window_bd_normminmax_nd.py

raise exceptions. I already tried to fix it and refactored method BoundaryDetector._adapt_on_event(). But this did not solve the problem. Interesting here: howto_oa_pp_004_rearranger_window_bd_normminmax_2d.py runs properly since refactoring...

Furthermore, I can not remember why we added a scaler functionality to the boundary detector.

2 To Reproduce
Steps to reproduce the behavior:

  1. Run howto_oa_pp_004_rearranger_window_bd_normminmax_3d.py or howto_oa_pp_005_rearranger_window_bd_normminmax_nd.py

3 Expected behavior
Both howtos should not raise exceptions.

4 Screenshots
If applicable, add screenshots to help explain your problem.

5 Additional Informations

5.1 Operating System

  • Linux
  • Windows
  • Mac OS
@detlefarend detlefarend added bug Something isn't working OA Online adaptivitiy labels May 20, 2023
@detlefarend detlefarend added this to the Sprint 2023/05 milestone May 20, 2023
@detlefarend detlefarend linked a pull request May 20, 2023 that will close this issue
2 tasks
@laxmikantbaheti
Copy link
Contributor

Hi @detlefarend , thanks for noticing the bug. It was a small bug with the creation of scaler array. I've fixed it.

@detlefarend
Copy link
Member Author

Hi @laxmikantbaheti, sry but I still get exceptions. Could you please check the howtos again? Thx!

@laxmikantbaheti
Copy link
Contributor

laxmikantbaheti commented May 21, 2023

Hi @detlefarend , I just checked, after pulling the latest merge commit to my local. The howtos are still working fine in my system. What exception is it raising for you?

@laxmikantbaheti
Copy link
Contributor

Hi @detlefarend , Sorry, I forgot to answer about the scaler:
The scaler was to increase the boundaries by a factor of the detected boundaries. Thus, avoiding the repeated adaptations in a given region for smaller changes. However, this is optional, and is set to 1 by default.

@detlefarend
Copy link
Member Author

Hi @detlefarend , I just checked, after pulling the latest merge commit to my local. The howtos are still working fine in my system. What exception is it raising for you?

I am currently not on my pc. I have run the howtos under Linux with the latest version of numpy and matplotlib. Maybe thats the problem...

@detlefarend
Copy link
Member Author

Hi @laxmikantbaheti, I analyzed the problem further. It is a problem with the latest version of numpy. The howtos run properly in version 1.23.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working OA Online adaptivitiy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants