-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Workflow Window/BoundaryDetector raises exception #753
Comments
Hi @detlefarend , thanks for noticing the bug. It was a small bug with the creation of scaler array. I've fixed it. |
Hi @laxmikantbaheti, sry but I still get exceptions. Could you please check the howtos again? Thx! |
Hi @detlefarend , I just checked, after pulling the latest merge commit to my local. The howtos are still working fine in my system. What exception is it raising for you? |
Hi @detlefarend , Sorry, I forgot to answer about the scaler: |
I am currently not on my pc. I have run the howtos under Linux with the latest version of numpy and matplotlib. Maybe thats the problem... |
Hi @laxmikantbaheti, I analyzed the problem further. It is a problem with the latest version of numpy. The howtos run properly in version 1.23.5. |
1 Describe the bug
I extended all howtos with task combination window+boundary detector as follows: I registered the _adapt_on_event method of the bd on the window for event Window.C_EVENT_DATA_REMOVED. Since then, the howtos
raise exceptions. I already tried to fix it and refactored method BoundaryDetector._adapt_on_event(). But this did not solve the problem. Interesting here: howto_oa_pp_004_rearranger_window_bd_normminmax_2d.py runs properly since refactoring...
Furthermore, I can not remember why we added a scaler functionality to the boundary detector.
2 To Reproduce
Steps to reproduce the behavior:
3 Expected behavior
Both howtos should not raise exceptions.
4 Screenshots
If applicable, add screenshots to help explain your problem.
5 Additional Informations
5.1 Operating System
The text was updated successfully, but these errors were encountered: