Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OA: Initial implementation of core classes #710

Merged
merged 190 commits into from
Sep 15, 2023
Merged

Conversation

detlefarend
Copy link
Member

Description

Background

Checklists:

  • Read the CONTRIBUTION guide (required).
  • Update the history on the source code (required).

@detlefarend detlefarend added enhancement New feature or request v1.4.0 v1.4.0 Separation of Wrapper Code OA Online adaptivitiy labels Apr 9, 2023
@detlefarend detlefarend added this to the Sprint 2023/04 milestone Apr 9, 2023
@detlefarend detlefarend self-assigned this Apr 9, 2023
@detlefarend
Copy link
Member Author

@laxmikantbaheti @steveyuwono @Syam47: Hi Guys, I propose the following design extension on class OATask. It introduces a new optional custom method _adapt_reverse() that adapts the inner policy by removing instances. Method _adapt() is now limited to policy adaptations on new instances:

grafik

@laxmikantbaheti: I have already refactored classes BoundaryDetector and NormalizerZTransform. I have two annotations:

a) BoundaryDetector
Doesn't currently implement a reverse adaptation.

b) NormalizerZTransform
Could you please add a window task to howto_oa_pp_002_normalization_of_streamed_data_ztransform to validate the reverse adaptation?

@laxmikantbaheti
Copy link
Contributor

laxmikantbaheti commented Apr 9, 2023

@laxmikantbaheti @steveyuwono @Syam47: Hi Guys, I propose the following design extension on class OATask. It introduces a new optional custom method _adapt_reverse() that adapts the inner policy by removing instances. Method _adapt() is now limited to policy adaptations on new instances:

grafik

@laxmikantbaheti: I have already refactored classes BoundaryDetector and NormalizerZTransform. I have two annotations:

a) BoundaryDetector Doesn't currently implement a reverse adaptation.

b) NormalizerZTransform Could you please add a window task to howto_oa_pp_002_normalization_of_streamed_data_ztransform to validate the reverse adaptation?

Hi @detlefarend , thanks for informing. I will validate the same as mentioned and let you know...

@laxmikantbaheti
Copy link
Contributor

Hi @detlefarend , the reverse_adapt works as intended in z transform. Thank you!

@detlefarend
Copy link
Member Author

Hi @detlefarend , the reverse_adapt works as intended in z transform. Thank you!

@laxmikantbaheti can it be that you forgot merging your changes? The howto is untouched.

@detlefarend
Copy link
Member Author

@laxmikantbaheti @Syam47 @steveyuwono I have restructured/renamed the class diagrams. They are organized in two sub-folders ./streams and ./systems now.

@laxmikantbaheti
Copy link
Contributor

Hi @detlefarend , the reverse_adapt works as intended in z transform. Thank you!

@laxmikantbaheti can it be that you forgot merging your changes? The howto is untouched.

Oops, error on my side. Fixed it.

@detlefarend detlefarend linked an issue Apr 10, 2023 that may be closed by this pull request
7 tasks
@detlefarend detlefarend linked an issue Apr 16, 2023 that may be closed by this pull request
4 tasks
steveyuwono and others added 27 commits August 23, 2023 14:37
@detlefarend detlefarend marked this pull request as ready for review September 15, 2023 12:18
@detlefarend detlefarend merged commit 26c0f54 into main Sep 15, 2023
9 checks passed
@detlefarend detlefarend deleted the oa/initial_design branch September 15, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment