Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refact: Improvements on Id and time stamp handling in classes Id, TStamp and Instance #986

Closed
4 of 5 tasks
detlefarend opened this issue May 19, 2024 · 0 comments · Fixed by #987
Closed
4 of 5 tasks

Refact: Improvements on Id and time stamp handling in classes Id, TStamp and Instance #986

detlefarend opened this issue May 19, 2024 · 0 comments · Fixed by #987
Assignees
@detlefarend
Labels
BF Basic Functions/Infrastructure quality Quality assurance refactoring Restructuring, renaming, simplification, understandability, ...

Comments

@detlefarend
Copy link
Member

detlefarend commented May 19, 2024 •
edited
Loading

Motivation
Currently, an individual Id handling is implemented in class Instance. This shall be refactored by adding class bf.various.Id as a parent class. Furthermore, a new property id shall be added to class bf.various.Id to simplify the access to the id of child classes. Same with class TStamp and a new property tstamp.

Benefit
Id handling is unified and made more pythonic.

Are the proposed changes backward compatible?

  • Yes
  • No

Related development objects

  • Class bf.streams.Instance
  • Class bf.various.Id
  • Class bf.various.TStamp
@detlefarend detlefarend added quality Quality assurance refactoring Restructuring, renaming, simplification, understandability, ... next release labels May 19, 2024
@detlefarend detlefarend self-assigned this May 19, 2024
@detlefarend detlefarend added the BF Basic Functions/Infrastructure label May 19, 2024
detlefarend added a commit that referenced this issue May 19, 2024
@detlefarend
Refact: Improvements on Id handling in classes Id and Instance #986
0764218
@detlefarend detlefarend linked a pull request May 19, 2024 that will close this issue
Refact: Improvements on Id handling in classes Id and Instance #986 #987
Merged
@detlefarend detlefarend changed the title Refact: Improvements on Id handling in classes Id and Instance Refact: Improvements on Id and time stamp handling in classes Id, TStamp and Instance May 19, 2024
detlefarend added a commit that referenced this issue May 20, 2024
@detlefarend
Merge pull request #987 from fhswf/bf/streams/instances
a4c7a05 
Refact: Improvements on Id handling in classes Id and Instance #986
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@detlefarend detlefarend

Labels
BF Basic Functions/Infrastructure quality Quality assurance refactoring Restructuring, renaming, simplification, understandability, ...
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refact: Improvements on Id handling in classes Id and Instance #986 fhswf/MLPro
1 participant
@detlefarend