Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refact: Improvements on Id handling in classes Id and Instance #986 #987

Merged
merged 1 commit into from
May 20, 2024

Conversation

detlefarend
Copy link
Member

No description provided.

@detlefarend detlefarend self-assigned this May 19, 2024
@detlefarend detlefarend added the BF Basic Functions/Infrastructure label May 19, 2024
@detlefarend
Copy link
Member Author

Hi guys, I unified and extended the handling of ids and time stamps of Instances. Issue #987 changed the following things on an instance:

  • the id of an instance can now be accessed (read/write) directly like inst.id = 5
  • the time stamp of an instance can also be accessed directly like inst.tstamp = timedate.now()
  • an instance has now always a time stamp. It is equal to the id if not set explicitly to a real time stamp

Copy link
Collaborator

@steveyuwono steveyuwono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Detlef,

I have tracked the files changed. Other than failing on unit test under Python 3.12, it looks good to me.

@detlefarend detlefarend merged commit a4c7a05 into main May 20, 2024
6 of 10 checks passed
@detlefarend detlefarend deleted the bf/streams/instances branch May 20, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BF Basic Functions/Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refact: Improvements on Id and time stamp handling in classes Id, TStamp and Instance
2 participants