fix gostream compatibility #686
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This unfortunately doesn't work as the gostream and network stream interfaces aren't the same (tests will fail). ref libp2p/go-libp2p-gostream#67. I'm not sure exactly what Boost is leveraging the different interface for but we need to fix the dependency branch usage here. @dirkmc has the full context here to help resolve and is back on Monday. |
|
I've added a commit to libp2p/go-libp2p-gostream#67 so that it uses network.Stream instead of gostream.Stream |
rvagg
added a commit
that referenced
this pull request
Nov 25, 2022
rvagg
added a commit
that referenced
this pull request
Nov 25, 2022
|
hopefully solved @ #1009 |
|
Closing in favor of #1009 |
dirkmc
pushed a commit
that referenced
this pull request
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting this while trying to import boost:
It seems that
gostreamnow usesnetwork.Streaminstead ofgostream.Stream. This makes boost compatible with it again