Expose some read-only methods on the underlying Stream interface #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conn.go
Outdated
| @@ -11,12 +11,20 @@ import ( | |||
| "github.com/libp2p/go-libp2p-core/protocol" | |||
| ) | |||
|
|
|||
| // Stream is a subset of the read-only methods on the network.Stream interface | |||
| type Stream interface { | |||
There was a problem hiding this comment.
Why can't we use the network.Stream interface?
There was a problem hiding this comment.
Good point - I changed the code to override network.Stream instead of re-implementing each of its methods to call the underlying implementation
…into feat/stream-id
|
@marten-seemann sorry for taking so long to follow up on this - could you please take another look when you get a chance 🙏 |
marten-seemann
approved these changes
Aug 16, 2022
|
@marten-seemann could you please make a release of gostream that targets this commit 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful to clients of the library who want to cast the
net.Conninstance into agostream.Streaminstance, so as to be able to read particulars of the underlying stream (eg the stream ID).A concrete use case: a client of the library wants to listen to network events, and needs to be able to get the stream ID from the connection to identify which events pertain to the connection.