basic EVM smart contract actor #517

vyzo · 2022-08-11T14:04:00Z

Description by @raulk

This contains the implementation of a basic EVM smart contract actor, based on what currently lives https://github.com/filecoin-project/fvm-evm/, but simplified to account for new designs around account abstraction and extensible addressing at the protocol level.

Supported features

Take init EVM bytecode in the constructor
Initialize a smart contract from that bytecode
Create the storage data structures in state (EVM storage is mapped to an IPLD HAMT, this will be optimised in the near future)
Run self-contained EVM smart contracts that do not call any other contracts/actors

Not supported yet

REVERT and SELFDESTRUCT are nor properly implemented
Ethereum precompiles EVM runtime: handle Ethereum precompiles ref-fvm#695
CALLS or DELEGATECALLs Handling Ethereum calls ref-fvm#718
Many static opcodes: EVM runtime: Map FVM context info to EVM opcodes ref-fvm#689
Correct Ethereum gas accounting
Ethereum logs Technical design: Logs and events ref-fvm#728

The memory management needs to be reviewed entirely.

In other words, there is still a ton of work to do, but this introduces an initial landmark to set as a departure point for all upcoming work.

The EVM actor has been included in the bundle produced by this repo.

Once this PR is merged, the https://github.com/filecoin-project/fvm-evm/ repo can be archived.

raulk · 2022-08-11T20:24:05Z

Our EVM implementation is a fork of https://github.com/vorot93/evmodin with several changes, amongst which are:

Removed support for continuations. We don't expect to use this feature in FVM.
Removed support for tracing. We may want to re-introduce this at some point proxying over to the debug::log syscall.
All instructions under instructions/ have been #[inlined].
The Host trait has been removed and substituted by a System concrete type that uses the FVM SDK (and thus depends on the actor Wasm sandbox). I think we will need to restore this trait for testing purposes.
The Memory is now backed by BytesVec instead of a Vec; it exposes a method to grow it, but we need to check that it's being called from every possible point.
Message#code_address has been removed; we may need to reintroduce when we start handling delegate call.
Opcode/EVM evolution throughout Ethereum's history has been removed. This version supports the Berlin hardfork.
Bytecode processing has lost features, e.g. code padding (not sure if this was an implementation detail), once-only jumpdest table population, etc. I think this is connected with the fact that we removed continuations and other unnecessary features, but gotta check.

karim-agha · 2022-08-12T16:57:50Z

I would recommend using the “toronto-demo” branch. It has more progress than master

this requried quite a bit of surgery...

Unfortunately this makes us depend on a branch of the bundler tool, but it's acceptable for now.

… only method

…e method

These mappings will not be managed by the EVM actor, but rather by the environment through address classes.

raulk · 2022-08-17T13:33:27Z

actors/evm/src/lib.rs

+        // create an instance of the platform abstraction layer -- note: do we even need this?
+        let system = System::new(rt, init_contract_state_cid).map_err(|e| {
+            ActorError::unspecified(format!("failed to create execution abstraction layer: {e:?}"))
+        })?;


We will need to reintroduce a trait here (like evmodin had Host) to make this abstraction layer useful for testing.

raulk · 2022-08-17T13:34:34Z

actors/evm/src/lib.rs

+
+            let state = State::new(
+                rt.store(),
+                RawBytes::new(contract_bytecode.to_vec()),


nit: This is a mouthful to read as a parameter, would probably extract it to a local var and name it for what it is (evm_bytecode_bytes, or something).

raulk · 2022-08-17T13:35:52Z

actors/evm/src/lib.rs

+        // TODO this is fine in a transaction for now, as we don't have yet cross-contact calls
+        //      some refactoring will be needed when we start making cross contract calls.
+        rt.transaction(|state: &mut State, rt| {


Yes, all of this will evolve as we implement https://github.com/filecoin-project/fvm-specs/issues/107.

raulk · 2022-08-17T13:36:59Z

actors/evm/src/lib.rs

+    {
+        rt.validate_immediate_caller_accept_any()?;
+
+        if params.bytecode.len() > MAX_CODE_SIZE {


I'd actually call this field init_code because that's what the Ethereum protocol calls it (it's the constructor code).

raulk · 2022-08-17T13:38:06Z

actors/evm/src/interpreter/instructions/storage.rs

+#[inline]
+pub fn sload<'r, BS: Blockstore, RT: Runtime<BS>>(
+    state: &mut ExecutionState,
+    platform: &'r System<'r, BS, RT>,


There's some naming incongruence left over from past refactors. Platform/System/Host... Need to fix this eventually.

raulk

There are obviously many TODOs, many bugs lurking, and many things that will get rewritten, but it serves as a reasonable starting point. I'm happy to merge this into next and continue iterating there.

raulk · 2022-08-17T13:45:30Z

Ah, I also moved my notes on evmodin divergence to a README.md file under the interpreter module: https://github.com/filecoin-project/builtin-actors/pull/517/files#diff-4ff2e70b4b59321d541e648b02188a6139aefb30079fea0c467e3b6c23415009R1

Co-authored-by: Raúl Kripalani <raul@protocol.ai>

vyzo and others added 3 commits August 11, 2022 17:02

lift fvm-evm into evm actor

a26d0d9

rename module {interp=>interpreter}.

d6c048c

retain evmodin's Apache v2 license.

9e1358a

vyzo and others added 5 commits August 13, 2022 01:24

integrate toronto-demo branch changes

a3a729b

fix evm actor state

65533a3

rustfmt

4b05e9c

make actor constructor initialize the contract

d9ce5c1

this requried quite a bit of surgery...

fix test compilation errors and clippy warnings.

f782b9f

raulk force-pushed the next-evm branch from 8ac9939 to f782b9f Compare August 15, 2022 20:11

raulk mentioned this pull request Aug 16, 2022

shared: add EVM built-in actor type. filecoin-project/ref-fvm#715

Merged

vyzo and others added 17 commits August 16, 2022 21:31

rename EvmRuntimeActor to EvmContractActor

f4d6e0d

implement invoke contract

9f159b5

rustfmt

e40e617

include EVM actor in the bundle; upgrade deps.

97b1bbb

Unfortunately this makes us depend on a branch of the bundler tool, but it's acceptable for now.

Cargo: use fvm_shared 0.9.0

a954a08

cargo lock

b884ed1

add EVM_ACTOR_CODE_ID to test utils

6245f8b

Runtime should implement MessageInfo

1477bb7

implement call_value and origin context calls

266dbe5

fix handling of reverts; it is not an execution error if it is a view…

be93739

… only method

basic evm test

f375ef1

cargo lock

ff0de7e

ignore failing txn decoding tests (no ecrecover yet)

9e8e4b3

rustfmt

7674096

no need to mixin MessageInfo in Runtime, it is accessible from messag…

ed4047f

…e method

fix stuff related to Type::EVM

2f42921

cargo lock

a32705a

vyzo changed the title ~~[WIP] EVM actor~~ EVM actor Aug 16, 2022

vyzo added 2 commits August 17, 2022 01:17

rustfmt

6a7945e

fix clippy

560d0a2

vyzo force-pushed the next-evm branch from 5d32cc9 to dbaf8a7 Compare August 16, 2022 22:52

allow unit err for clippy

bbd1283

vyzo force-pushed the next-evm branch from dbaf8a7 to bbd1283 Compare August 16, 2022 22:54

raulk added 2 commits August 17, 2022 12:38

remove account abstractions over Ethereum and Filecoin addresses.

70e0257

These mappings will not be managed by the EVM actor, but rather by the environment through address classes.

suppress clippy::result_unit_err warning.

8606cba

raulk changed the title ~~EVM actor~~ initial EVM smart contract actor Aug 17, 2022

raulk changed the title ~~initial EVM smart contract actor~~ basic EVM smart contract actor Aug 17, 2022

improve EVM interpreter README.

096f261

raulk marked this pull request as ready for review August 17, 2022 13:29

raulk added the FEVM label Aug 17, 2022

raulk approved these changes Aug 17, 2022

View reviewed changes

raulk requested review from Stebalien and mriise August 17, 2022 22:24

raulk merged commit 36ec85a into next Aug 18, 2022

raulk deleted the next-evm branch August 18, 2022 10:20

raulk mentioned this pull request Aug 18, 2022

fvm-evm: absorb into built-in actors filecoin-project/ref-fvm#693

Closed

3 tasks

shamb0 pushed a commit to shamb0/builtin-actors that referenced this pull request Oct 3, 2022

basic EVM smart contract actor (filecoin-project#517)

8b9b145

Co-authored-by: Raúl Kripalani <raul@protocol.ai>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

basic EVM smart contract actor #517

basic EVM smart contract actor #517

vyzo commented Aug 11, 2022 •

edited by raulk

Loading

raulk commented Aug 11, 2022

karim-agha commented Aug 12, 2022

raulk Aug 17, 2022

raulk Aug 17, 2022

raulk Aug 17, 2022

raulk Aug 17, 2022

raulk Aug 17, 2022

raulk left a comment

raulk commented Aug 17, 2022

basic EVM smart contract actor #517

basic EVM smart contract actor #517

Conversation

vyzo commented Aug 11, 2022 • edited by raulk Loading

Supported features

Not supported yet

raulk commented Aug 11, 2022

karim-agha commented Aug 12, 2022

raulk Aug 17, 2022

Choose a reason for hiding this comment

raulk Aug 17, 2022

Choose a reason for hiding this comment

raulk Aug 17, 2022

Choose a reason for hiding this comment

raulk Aug 17, 2022

Choose a reason for hiding this comment

raulk Aug 17, 2022

Choose a reason for hiding this comment

raulk left a comment

Choose a reason for hiding this comment

raulk commented Aug 17, 2022

vyzo commented Aug 11, 2022 •

edited by raulk

Loading