feat: return faulty sectors #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porcuquine
approved these changes
Sep 8, 2020
If Window PoSt fails, return the faulty sectors. They are part of the error response. The `faulty_sectors_len` is the number of faulty sectors (0 if there aren't any faulty sectors) and `faulty_sectors_ptr` points to an array of unsigned 64-bit integers, representing the sector IDs.
vmx
force-pushed
the
faulty-sectors-error
branch
from
65dcdfd
to
6419af8
Compare
|
This should NOT be merged until the corresponding Go changes (which should be pretty minimal) are in. |
magik6k
approved these changes
Sep 10, 2020
Kubuxu
reviewed
Sep 10, 2020
| Cap int | ||
| } | ||
|
|
||
| (*sliceHeader)(unsafe.Pointer(&ptr)).Len = int(l) // don't worry about it |
There was a problem hiding this comment.
Is this needed? Isn't just the fact that we are inerating up to l below enough?
There was a problem hiding this comment.
The generated cgo code doesn't set it, so we panic on out-of-bounds
whyrusleeping
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Window PoSt fails, return the faulty sectors. They are part of the
error response. The
faulty_sectors_lenis the number of faulty sectors(0 if there aren't any faulty sectors) and
faulty_sectors_ptrpointsto an array of unsigned 64-bit integers, representing the sector IDs.