Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windowed post generation now returns faulty sectors #3710

Merged
merged 8 commits into from
Sep 11, 2020

Conversation

whyrusleeping
Copy link
Member

No description provided.

@whyrusleeping
Copy link
Member Author

whyrusleeping commented Sep 9, 2020

return nil, xerrors.Errorf("running post failed: %w", err)
skipCount += uint64(len(ps))
for _, sector := range ps {
postSkipped.Set(uint64(sector.Number))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to fix Sealer.pubSectorToPriv in ffiwrapper/verifier_cgo.go to actually do this. Instead of simply skipping missing sectors, it needs to replace them with the first non-missing sector.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't pass this bitfield straight to the submitPost message - we retry the whole thing (with the loop at L342), assembling the set of sectors from scratch. This bitfield is only used to subtract sectors we couldn't prove in the previous try (L358)

@maxvint
Copy link

maxvint commented Sep 10, 2020

pls give this issue more gas... we need it to be merged ASAP.

@magik6k magik6k changed the base branch from master to ntwk-0.7.0 September 10, 2020 20:18
@magik6k magik6k changed the base branch from ntwk-0.7.0 to master September 10, 2020 21:00
@magik6k
Copy link
Contributor

magik6k commented Sep 11, 2020

(Works on my miner, did 2 posts with it, successfully)

@magik6k magik6k merged commit b89aa02 into master Sep 11, 2020
@btcioner
Copy link

--- stderr
thread 'main' panicked at 'Unable to find libclang: "couldn\'t find any valid shared libraries matching: [\'libclang.so\', \'libclang-*.so\', \'libclang.so.*\', \'libclang-*.so.*\'], set the `LIBCLANG_PATH` environment variable to a path where one of these files can be found (invalid: [])"', /home/topx/.cargo/registry/src/mirrors.tuna.tsinghua.edu.cn-df7c3c540f42cdbd/bindgen-0.54.0/src/lib.rs:1959:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Build error

@btcioner
Copy link

run sudo apt-get install libclang-dev,fix build error

@httpservlet
Copy link

Intel sync node instruction error

@mostcute
Copy link

Does this solution solve the problem “sanity check err” ?

@httpservlet
Copy link

httpservlet commented Sep 12, 2020

@whyrusleeping @magik6k A new problem has arisen
I update the latest master, Log shows are done many times computing window PoSt and generate window PoSt skipped sectors, Resulting in timeout
image
image

@kwuaint
Copy link
Contributor

kwuaint commented Sep 12, 2020

@FIRST "computing window PoSt" then "generate window PoSt skipped sectors", and do "computing window PoSt" and "generate window PoSt skipped sectors" again...

consume a lot of time.

It there's 10 or 50 sectors, it's OK. But there's 2349 sectors in one deadline, so the procedure can finished in half hour. It cause timeout and no SubmitWindowedPoSt, and winpost fail, the 2349 sectors turn to faults totally.
I think the root cause(faulty sectors #3710, #3710) found ,but we should rewrite the code.

@Kubuxu Kubuxu deleted the feat/window-post-faulty-sectors branch November 25, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants