Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fire cancel locally even if remote cancel fails #120

Merged
merged 2 commits into from
Nov 30, 2020
Merged

Fire cancel locally even if remote cancel fails #120

merged 2 commits into from
Nov 30, 2020

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Nov 27, 2020

CloseDataTransferChannel should fire "cancel" on the local FSM, even if sending a "cancel" message to the remote peer fails

@dirkmc dirkmc mentioned this pull request Nov 27, 2020
Merged
Base automatically changed from fix/open-stream-timeout to master November 30, 2020 14:31
@dirkmc dirkmc merged commit b9b87cb into master Nov 30, 2020
@dirkmc dirkmc deleted the fix/fire-cancel-locally branch November 30, 2020 14:31
This was referenced Nov 30, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dirkmc @magik6k