Cancel transfer should cause Storage deal to fail #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmc
force-pushed
the
feat/cancel-transfer-fails-deal
branch
from
9523133
to
94cae7b
Compare
dirkmc
force-pushed
the
feat/cancel-transfer-fails-deal
branch
from
94cae7b
to
25afe9e
Compare
dirkmc
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on filecoin-project/go-data-transfer#119 filecoin-project/go-data-transfer#120
Addresses filecoin-project/lotus#4997
This PR modifies the client and provider FSMs to transition to "deal failing" when the data transfer for the deal is cancelled.
If there is no network connectivity, the other party in the data transfer will not detect the deal cancellation (because it's not possible for the party that cancels the transfer to send a "cancel" message across the wire).
We should fix this in a follow-up PR.
Additionally we should ensure cancel transfer causes retrieval deals to fail in a follow-up PR. Issue: filecoin-project/lotus#5034