Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove restart ack timeout #211

Merged
merged 2 commits into from
Jun 2, 2021
Merged

Remove restart ack timeout #211

merged 2 commits into from
Jun 2, 2021

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Jun 1, 2021

This PR

  • removes the restart ack timeout
  • allows the accept and complete timeouts to be disabled

Because graphsync rate limits the number of requests for data that it will respond to, it's not possible to rely on these timeouts in uncontrolled environments.

More detail here: filecoin-project/lotus#6343 (comment)

@codecov-commenter
Copy link

Codecov Report

Merging #211 (914b702) into master (3a130c3) will decrease coverage by 0.05%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
- Coverage   65.05%   65.00%   -0.06%     
==========================================
  Files          24       24              
  Lines        2627     2600      -27     
==========================================
- Hits         1709     1690      -19     
+ Misses        575      570       -5     
+ Partials      343      340       -3     
Impacted Files Coverage Δ
channelmonitor/channelmonitor.go 72.63% <55.55%> (-1.57%) ⬇️
network/libp2p_impl.go 72.26% <0.00%> (+3.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a130c3...914b702. Read the comment docs.

@aarshkshah1992
Copy link
Collaborator

@dirkmc Why reported a problem because of this on Estuary

12D3KooWCVXs8P7iq6ao4XhfAmKWrEeuKFWCJgqe9jGDMTqHYBjw-12D3KooWDMpcct12Vb6jPXwjvLQHA2hoP8XKGbUZ2tpue1ydoZUm-1622579291962288043: after 16 consecutive restarts failed to transfer any data

Can we get this out as well in a Lotus/Markets release ? I don't think the recent Markets v1.4.0 change includes this PR.

@dirkmc
Copy link
Contributor Author

dirkmc commented Jun 2, 2021

It was merged into lotus last night:
filecoin-project/lotus#6369
I branched v1.6.0 off an earlier commit to avoid some other big refactors in go-data-transfer master - I wanted to have a minimal set of changes to reduce the chance of a regression. Planning to merge and test the other changes this week.

@dirkmc dirkmc merged commit 2af50e8 into master Jun 2, 2021
@dirkmc dirkmc deleted the feat/disable-timeouts branch June 2, 2021 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants