Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to markets-v1.4.0 #6369

Merged
merged 4 commits into from
Jun 1, 2021
Merged

update to markets-v1.4.0 #6369

merged 4 commits into from
Jun 1, 2021

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Jun 1, 2021 •
edited
Loading

Fixes #6343 #6297

  • Testground tests

    • This branch client <-> this branch miner
    • This branch client <-> lotus v1.9.0 miner
    • lotus v1.9.0 client <-> this branch miner

  • Manual tests

    • This branch client <-> this branch miner
    • This branch client <-> lotus v1.9.0 miner
    • lotus v1.9.0 client <-> this branch miner

  • Release go-data-transfer and go-fil-markets

@dirkmc
Copy link
Contributor Author

dirkmc commented Jun 1, 2021

Testground Tests:

Lotus v1.9.0:
  Commit:  ada7f97
  Tag:     909427826938.dkr.ecr.eu-west-2.amazonaws.com/testground-eu-west-2-lotus-soup:a8621258c46e

Lotus master + markets v1.4.0:
  Commit:  8997ed5
  Tag:     909427826938.dkr.ecr.eu-west-2.amazonaws.com/testground-eu-west-2-lotus-soup:e142fdbab535


[v1.9.0 client / This branch miner]

testground run composition -f ./_compositions/baseline-k8s-1-1-versions.toml
  miners:  909427826938.dkr.ecr.eu-west-2.amazonaws.com/testground-eu-west-2-lotus-soup:e142fdbab535
  clients: 909427826938.dkr.ecr.eu-west-2.amazonaws.com/testground-eu-west-2-lotus-soup:a8621258c46e

✅ https://ci.testground.ipfs.team/logs?task_id=c2r705avmgl1fc861jk0


[This branch client / v1.9.0 miner]

testground run composition -f ./_compositions/baseline-k8s-1-1-versions.toml
  miners:  909427826938.dkr.ecr.eu-west-2.amazonaws.com/testground-eu-west-2-lotus-soup:a8621258c46e
  clients: 909427826938.dkr.ecr.eu-west-2.amazonaws.com/testground-eu-west-2-lotus-soup:e142fdbab535

✅ https://ci.testground.ipfs.team/logs?task_id=c2r7432vmgl1fc861jkg

@dirkmc dirkmc marked this pull request as ready for review June 1, 2021 19:46
@magik6k magik6k merged commit aad13ba into master Jun 1, 2021
@magik6k magik6k deleted the feat/markets-1.4.0 branch June 1, 2021 21:35
aarshkshah1992
aarshkshah1992 reviewed Jun 2, 2021
View reviewed changes
testplans/lotus-soup/go.mod
@@ -8,19 +8,20 @@ require (
github.com/davecgh/go-spew v1.1.1
github.com/drand/drand v1.2.1
github.com/filecoin-project/go-address v0.0.5
github.com/filecoin-project/go-data-transfer v1.1.1-0.20210428151930-29bfef7e037e
github.com/filecoin-project/go-data-transfer v1.4.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dirkmc Shouldn't this be v1.5.0 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the go.mod for lotus-soup so the deps just need to match the lotus dep.
The lotus dep is v1.9.0, which depends on go-data-transfer v1.4.3:
https://github.com/filecoin-project/lotus/blob/v1.9.0/go.mod#L35

@dirkmc dirkmc mentioned this pull request Jun 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarshkshah1992 aarshkshah1992 aarshkshah1992 left review comments

@magik6k magik6k magik6k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Deal Making Issue] Storage AND Retrieval deals time out waiting for an Accept message
4 participants
@dirkmc @aarshkshah1992 @magik6k @jacobheun