Cleanup errors #88
Merged
Cleanup errors #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahhoward
changed the base branch from
master
to
feat/add-bool-to-revalidator-interfaces
aarshkshah1992
approved these changes
Sep 29, 2020
| for testCase, isPull := range testCases { | ||
| t.Run(testCase, func(t *testing.T) { | ||
| // ctx, cancel := context.WithTimeout(ctx, 5*time.Second) | ||
| // defer cancel() |
| } | ||
| // send an error, but only if we haven't already errored for some reason | ||
| if chst.Status() != datatransfer.Failing && chst.Status() != datatransfer.Failed { | ||
| return m.channels.Error(chid, datatransfer.ErrIncomplete) |
There was a problem hiding this comment.
@hannahhoward There's no test for ErrIncomplete.
hannahhoward
force-pushed
the
feat/add-bool-to-revalidator-interfaces
branch
from
f7d85bd
to
a400317
Compare
… for a need to revalidate (#87) * feat(revalidator): add handled bool Previously, the revalidators were very ambiguous in identifying if they had actually handled a request for a revalidation check or not -- a "nil, nil" or "voucher result, nil" was interpreted as not being handled. This is unfortunate, cause particularly a "voucher result, nil" is an indication the request is handled by this check, and we should stop processing other revalidators that might override the value with "nil, nil". We now add a boolean to disambiguate whether the revalidator "recognized" this request --- if true, processing stops. * style(comments): fix types
cleanup errors -- move more error codes to proper types and insure single error dispatched
hannahhoward
force-pushed
the
feat/cleanup-errors
branch
from
49fa579
to
cec9d80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Implementation