Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup errors #88

Merged
merged 3 commits into from
Sep 29, 2020
Merged

Cleanup errors #88

merged 3 commits into from
Sep 29, 2020

Commits on Sep 29, 2020

  1. Disambiguate whether a revalidator recognized a request when checking… 

    … for a need to revalidate (#87)

* feat(revalidator): add handled bool

Previously, the revalidators were very ambiguous in identifying if they had actually handled a
request for a revalidation check or not -- a "nil, nil" or "voucher result, nil" was interpreted as
not being handled. This is unfortunate, cause particularly a "voucher result, nil" is an indication
the request is handled by this check, and we should stop processing other revalidators that might
override the value with "nil, nil". We now add a boolean to disambiguate whether the revalidator
"recognized" this request --- if true, processing stops.

* style(comments): fix types
    @hannahhoward
    hannahhoward committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    8a1e460 View commit details
    Browse the repository at this point in the history

  2. feat(impl): cleanup errors 

    cleanup errors -- move more error codes to proper types and insure single error dispatched
    @hannahhoward
    hannahhoward committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    f1e5fe0 View commit details
    Browse the repository at this point in the history

  3. test(impl): add unit test for incomplete response

    @hannahhoward
    hannahhoward committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    cec9d80 View commit details
    Browse the repository at this point in the history