Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specs actors v0.6 #274

Merged
merged 3 commits into from
Jun 15, 2020
Merged

specs actors v0.6 #274

merged 3 commits into from
Jun 15, 2020

Conversation

magik6k
Copy link
Collaborator

@magik6k magik6k commented Jun 15, 2020

Copy link
Contributor

@laser laser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite straightforward.

@whyrusleeping
Copy link
Member

tests fail and merge conflict, but you know, lgtm

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2020

Codecov Report

Merging #274 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #274   +/-   ##
=======================================
  Coverage   63.75%   63.75%           
=======================================
  Files          40       40           
  Lines        2416     2416           
=======================================
  Hits         1540     1540           
  Misses        752      752           
  Partials      124      124           
Impacted Files Coverage Δ
storagemarket/impl/client.go 0.00% <ø> (ø)
storagemarket/impl/provider.go 5.02% <ø> (ø)
storagemarket/impl/providerutils/providerutils.go 95.46% <ø> (ø)
storagemarket/types.go 33.34% <ø> (ø)
pieceio/pieceio.go 81.97% <100.00%> (ø)
storagemarket/impl/clientutils/clientutils.go 78.95% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a88b8a...8bb5977. Read the comment docs.

@hannahhoward hannahhoward merged commit c8c329c into master Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants