This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
specs-actors v0.6 #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 15, 2020
magik6k
force-pushed
the
deps/actors-v0.6.0
branch
from
7d09fa8 to
3d1225b
Compare
whyrusleeping
approved these changes
Jun 15, 2020
laser
reviewed
Jun 15, 2020
|
|
||
| _ struct{} // guard against nameless init | ||
| } | ||
|
|
||
| func sizeFromConfig(cfg Config) (abi.SectorSize, error) { | ||
| if cfg.SealProofType == abi.RegisteredProof(0) { |
There was a problem hiding this comment.
@magik6k - Why did you remove this if-statement? Is it no longer needed now that we have the new types?
There was a problem hiding this comment.
The 2K seal proof type is 0
|
@magik6k - Note: The |
Kubuxu
approved these changes
Jun 15, 2020
|
👍 I just checked in here to make sure I'm keeping track of the integration difficulty of actors changes for downstream consumers. Please feel free to tag me on "update actors" PRs and lmk if things are unnecessarily inconvenient. We do, of course, need to actually change some things now and then. |
aliensero
pushed a commit
to aliensero/sector-storage
that referenced
this pull request
Aug 5, 2020
…iled-state fix precommit1 failed state
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: