change the value of duration from endEpoch-startEpoch to sectorExpiry-sectorActivation #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-sectorActivation
rvagg
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
This makes sense to me. In actors we calculate duration the same way: https://github.com/filecoin-project/builtin-actors/blob/8d957d2901c0f2044417c268f0511324f591cb92/actors/miner/src/lib.rs#L5522-L5534
This code gets used in lotus for StateMinerPreCommitDepositForPower here: https://github.com/filecoin-project/lotus/blob/21abfc69fb552b92fa3ce223e863f1d582dec237/node/impl/full/state.go#L1463-L1468
But I'd like someone else who works more closely with this to verify this is correct. @magik6k @LexLuthr ?
rvagg
requested changes
Jul 15, 2024
|
@firesWu we have a 👍 on this from the miner code experts, thanks for catching it. Would you mind rebasing and switching your v12 change to v14? |
rvagg
pushed a commit
that referenced
this pull request
Jul 16, 2024
|
It was easy enough to do in a new PR @ #291 |
rvagg
pushed a commit
that referenced
this pull request
Jul 16, 2024
rvagg
pushed a commit
that referenced
this pull request
Jul 16, 2024
rvagg
pushed a commit
that referenced
this pull request
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the value
endepoch - startepochis used as theduration, the calculated initial collateral for real deal may be smaller than the actual value, leading to a failed execution of the provecommit msg execution.